[Unbound-users] patch: rrset-roundrobin/minimal-responses

[W.C.A. Wijngaards]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Daisuke,

On 04/07/2012 01:58 PM, Daisuke HIGASHI wrote:
> Hi all,
> 
> This patch adds two features to Unbound-1.4.16.

Excellent!  The patch is very small, and contains threadsafe code.
The queryID is a very good way to make the rrset rotate, and removes
my concern for speed.

The minimal-responses positive_answer() routine is fixed to detect
wildcards, so that the NSEC/NSEC3 records for wildcards are not
removed from the authority section.

And added documentation in the manpage and example config.  I did note
that minimal-responses is not RFC-conformant and may lose additional
data and thus necessitate roundtrips for clients that could have used
that additional data.

Thanks for this patch :-)

Best regards,
   Wouter

> 
> rrset-roundrobin: yes|no (default: no)
> 
> If yes, Unbound rotates RRSet order in response. This is almost
> same as Thijs Kinkhorst's implementation except that random number
> source is query-id.
> 
> 
> minimal-responses: yes|no (default: no)
> 
> If yes, Unbound doesn't insert authority/additional sections into
> response message when those sections are not required [1]. This is
> similar to BIND9's minimal-responses or Google Public DNS
> behavior.
> 
> Some points in favor: - reduces size of response significantly. in
> addition to bandwidth saving, it avoids TCP fallback all possible. 
> - improves performance slightly. 5-7% speed-up at my Core 2 duo
> laptop.
> 
> [1] minimal-response process is activated when RCODE is NOERROR
> and QTYPE matches one of rrset type in answer section. (i.e. the
> response is positive answer)
> 
> -- Daisuke HIGASHI <daisuke.higashi at gmail.com>
> 
> 
> 
> _______________________________________________ Unbound-users
> mailing list Unbound-users at unbound.net 
> http://unbound.nlnetlabs.nl/mailman/listinfo/unbound-users

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPg/vPAAoJEJ9vHC1+BF+N43YP/jVakda1VTkkMQYgbNLbnnTp
65XXaf+TDOTrT5fKM5X5novwDlh7jdDsfMOcnwuK/m0wb8mLCfjfC99k3i2mtKWO
FhSAa8hkdnfSb0MM1B4mf0SCTIwhifRJPQmlfuKpSbyGnkuVXEVOXAL+BDdm9XI+
grun81i5whMan7KifWEHaj1oijo3Wh9KwgH0jARERPmBYKIhFoT8dpy9Sp+6Wnay
EvF8GHYoYK3PSSUF3xeVFUCyM/+Ays5HqYhp7+upvTLEdVVbrBfugjMBaqRcfRG7
rUPIy1r0NnPW3HMtvtq1ybD+QTC5x5SxlXWyd/B5lQIaAs3CM2YCKt28h0EoZCFk
2Na8nVhhrsfkIv2YCHt00dtZyR5rycbX6UKpobko2eqEWi7cmjUdFgwHU/ryJXZi
E2ePpWKWSh25ayEHeKl8dymzmjIcH9pyWAVyumogmIOFk3ZWB36q9fyucOUxqKHW
uR44fteJhC14/EC1XNtyCxrdDStd0e+2Gq4gqVBcdm2IBc7KdqC18hlffG8bw8Hc
tVRlh/UDiGk+k1XqJHA6bPHS5cqtDx8b/WnwTrqbjFhk+MtKn7SS5CkFq6cMpPXJ
xoLF9ZP5qSBPsf4t7+x+OeyZNbTUeO1jS8S37+6Iu3bplUXfNLe/4Zv8nzKLYO0r
04gbVJKmsaGVzU5+wJoP
=B9Qt
-----END PGP SIGNATURE-----