[ldns-users] Documentation update suggestion for "ldns_rr_list * good_keys" structure

[Matthijs Mekking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Zbynek,

Fair enough. I have committed your suggestions to trunk. Thanks for
reporting.

Best regards,

Matthijs Mekking
NLnet Labs

Zbynek Michl wrote:
> Hello,
> 
> there is the following "good_keys" structure description at this time,
> e.g. in ldns_verify_rrsig_keylist() and similar functions:
> 
> "if this is a (initialized) list, the keys from keys that validate one
> of the signatures are added to it"
> 
> I guess it is a little bit confusing because it seems that key is copied
> to good_keys list, but only pointer to that key from keys is added
> actually. This could
> provoke user to use ldns_rr_list_deep_free() to free that structure
> instead of only ldns_rr_list_free() function.
> 
> So I suggest to update that description to:
> 
> "if this is a (initialized) list, the pointers to keys from keys that
> validate one of the signatures are added to it"
> 
> 
> Regards,
> Zbynek
> _______________________________________________
> ldns-users mailing list
> ldns-users at open.nlnetlabs.nl
> http://open.nlnetlabs.nl/mailman/listinfo/ldns-users

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQEcBAEBAgAGBQJLhl3TAAoJEA8yVCPsQCW5rNQH+gKIxJPqEaoxq9Cu0p4fyzF1
0EteusbjKEe588+MckNhZe4ZbckFb9CkrthLyuvZhQbAosMCPymids4v1IoLOH3J
CDIIXVXu8WqMpX9rGYfCWcpHGjvFenavTZqGjIhaFBKQxot1pNA7ITINSudVEDO8
ZsFDm+Iw8l8vL9HMkW5AIXKnTipS+rAIJU/UH3kzP2cHVuUNmMUS2d721xLxT8Ra
F2eaKDKbd2snXXi03SSn6sn9LQtzTEEwQHk0xHzYOukZ8RjRS36qcOpG9XjUonrX
V7w1RVW9SHLfWCPZ1LokbNMfX1VGpVTu/wjUBI5z0XlBHlfmgpKMkRAfPJAYlyk=
=uyX9
-----END PGP SIGNATURE-----