[ldns-users] Documentation update suggestion for "ldns_rr_list * good_keys" structure

Zbynek Michl zbynek.michl at nic.cz
Thu Feb 25 11:04:11 UTC 2010


Hello,

there is the following "good_keys" structure description at this time, e.g. in 
ldns_verify_rrsig_keylist() and similar functions:

"if this is a (initialized) list, the keys from keys that validate one of the 
signatures are added to it"

I guess it is a little bit confusing because it seems that key is copied to 
good_keys list, but only pointer to that key from keys is added actually. This 
could
provoke user to use ldns_rr_list_deep_free() to free that structure instead of 
only ldns_rr_list_free() function.

So I suggest to update that description to:

"if this is a (initialized) list, the pointers to keys from keys that validate 
one of the signatures are added to it"


Regards,
Zbynek



More information about the ldns-users mailing list