[ldns-users] ldns_resolver_new_frm_fp_l() comment lines bug

[Matthijs Mekking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ah yes, you are right.

The parsing goes wrong, we hit the limit too early and we don't allow
for the word to be closed with the '\0' character. A fix is in trunk r3236.

Thanks!

Matthijs

Zbynek Michl wrote:
> Hi Matthijs,
> 
> I have got simple resolv.conf:
> 
> nameserver 172.20.20.40
> search mydomain.cz
> 
> and using function ldns_resolver_new_frm_file(&res, NULL) I am getting
> empty _searchlist (nameserver is read correctly). So what could be wrong?
> 
> Thanks,
> Zbynek
> 
> On 21.4.2010 10:47, Matthijs Mekking wrote:
> Hi Zbynek,
> 
> What seems to be the error? It reads my resolv.conf (including search
> line) fine.
> 
> Best regards,
> 
> Matthijs
> 
> Zbynek Michl wrote:
>>>> Hi Wouter,
>>>>
>>>> there is probably another bug in ldns_resolver_new_frm_fp_l(). Function
>>>> can not read "search" list from resolv.conf.
>>>>
>>>> Thanks,
>>>> Zbynek
>>>>
>>>> On 18.3.2010 16:40, W.C.A. Wijngaards wrote:
>>>> Hi Zbynek,
>>>>
>>>> Fixed in svn r 3210
>>>>
>>>> The example you gave did not fail for me?  It failed with different
>>>> whitespace.  But anyway, the comment handling did not properly handle
>>>> skipping onto the next line, so I fixed that :-)
>>>>
>>>> Thanks for the report!
>>>>      Wouter
>>>>
>>>> On 03/18/2010 02:39 PM, Zbynek Michl wrote:
>>>>>>> there is probably a bug in ldns_resolver_new_frm_fp_l() function.
>>>>>>> When I
>>>>>>> use ldns_resolver_new_frm_file() to read /etc/resolv.conf, it
>>>>>>> incorrectly handles comment lines.
>>>>>>>
>>>>>>> So it seems if some line is commented out, then the next line is
>>>>>>> ommited
>>>>>>> too.
> _______________________________________________
> ldns-users mailing list
> ldns-users at open.nlnetlabs.nl
> http://open.nlnetlabs.nl/mailman/listinfo/ldns-users
>>>> _______________________________________________
>>>> ldns-users mailing list
>>>> ldns-users at open.nlnetlabs.nl
>>>> http://open.nlnetlabs.nl/mailman/listinfo/ldns-users
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQEcBAEBAgAGBQJLzuK8AAoJEA8yVCPsQCW5/NcIALtpYDFyo3XbaO2ezkbqCvoj
oUa1f9vLNiFHqKOFKInVerMwoRulNuQy7bomNVYmUACePbdjbW6u8WBJhDkD2JJc
OaO3bKwU8uyulLqK06DDhpF9KGDbXpi8vTfbTJvypsAlj12zLZsXRWqPtY/pr+GQ
Mj/g5dsm8mgL/rATtbaOe3vzElpubLRVstvmph6pNc9IqR7GdSrCaSNYTZ1LtM6k
f+OZQXG3DFnX3qxkTTbnYHJYpKqnmhmnutPfDiYpJI17HG18v1yxnVYbkuj/dnok
MIKwpPdK7BDxKmFUsmO27UNLls8ko/ecd+x35vq/n0vE4nGceZSNifXde+oX8Co=
=0yqM
-----END PGP SIGNATURE-----