[Dnssec-trigger] patchset: incorporate stuff from contrib

W.C.A. Wijngaards wouter at nlnetlabs.nl
Fri Mar 28 09:31:26 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Pavel,

On 03/25/2014 05:04 PM, Pavel Simerda wrote:
> Hi,
> 
> I'm sending a set of patches that incorporate other stuff from the
> contrib directory into the main tree and build/install system. The
> first two patches are pretty much straightforward, while the third
> causes the systemd files only be installed if when built
> --with-hooks=networkmanager.
> 
> The systemd files indeed expect dnssec-trigger-script to exist and
> run, but this could be easily changed by prefixing the path with
> '-' meaning that the called script is not required to run and
> finish successfully and then AC_ARG_WITH(systemdsystemunitdir,
> ...) could be used with some magic to detect
> /usr/lib/systemd/system automatically. Looking forward to any
> opinions.

Thanks for all these patches. I applied this one, but changed a bit. I
added install -d that creates the directory, so that the install
always succeeds.  You need that anyway, so that when you build an rpm
against an empty destdir the install will succeed.  The configure
logic to optionally not-install systemd when systemd is not present is
optional; the files are harmless I think if systemd is not there.

Best regards,
   Wouter

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTNUFtAAoJEJ9vHC1+BF+NCCgP/04h0Q4VslNHLreRgx71eInX
NuGGkPiwpXSNbTVXf3BS0d4sFZTq854qjidz+m8eaYjtY02Lf5UAgkJ4wOkzBguf
EE98YGBj2FJtHhv+Fe5tOxDInVdmtEwv0+WCcAbdAruFs+E78XZ1M/twF6HajeXC
MGQNztWXm11NQ7kQ/dgFomRpNA4LHTlg5LOZT0ipXFpLGW5u4Ct3PuM6C3DCL1Wo
RDoFH222rJkvMcBUWDWVQhVIzGNvAnYhbUbkKq1qwKedUFHb9XaWxprjWUMsGXFp
d8it/Gm1As9tz5JQg6i/Dlty5TZKwJNwTHyX/AspHP1QzomlfncRto+LAGSMozMu
8LEGWHohlMTbEmsi1hqXqRK4MANPCGt6Hq5233wahxVqaUT7GT1SkWsYFhLstw1V
15z3u9sUX7JaCJUpYrdWVJyQtycYjO0Q8yAtVrFeXKZg/5T37YHhnAnKI738F7f9
a+wu7Vz0ogh8ucbTrXXCkvfqLmC1hHry1Ev3Q/Fqwvd0eCHZH9eCUyN3oVcdEOLY
p1OzxJwpSutzAJt3fqGSJST4C9xcY10IS1P+t13PBZqNtD4KDV1FntYPlFgyfNpV
QxHhSgVkNsyQUwQrhBa4W2m4mtfq+T5zBWWYTTsRSJvb4UYYoOqumFrHMgLAvf1f
XSg93R5RAPq3WvFd22sE
=2cWU
-----END PGP SIGNATURE-----



More information about the dnssec-trigger mailing list