internal error: looping module stopped

[Ralph Dolmans]

Hi Jacob,

I would like to know if this error also shows up when caps-for-id is not
enabled.

It might also be useful to know on which query name the looping occurs.
This will be logged on verbosity 3. If setting your verbosity to 3 is
not possible, you can apply below patch on 1.6.6 to always log the query
when the module is looping, and to log the module in which the looping
is happening.

Thanks,
-- Ralph


Index: services/mesh.c
===================================================================
--- services/mesh.c	(revision 4368)
+++ services/mesh.c	(working copy)
@@ -1310,8 +1310,9 @@
 	mstate->num_activated++;
 	if(mstate->num_activated > MESH_MAX_ACTIVATION) {
 		/* module is looping. Stop it. */
-		log_err("internal error: looping module stopped");
-		log_query_info(VERB_QUERY, "pass error for qstate",
+		log_err("internal error: looping module (%s) stopped",
+			mesh->mods.mod[mstate->s.curmod]->name);
+		log_query_info(NO_VERBOSE, "pass error for qstate",
 			&mstate->s.qinfo);
 		s = module_error;
 	}



On 07-10-17 00:15, Jacob Hoffman-Andrews wrote:
> I also got a number of these errors on an upgrade to Unbound 1.6.6, on a
> server doing about 100-300 qps. Similar config: use-caps-for-id, IPv6,
> DNSSEC. No non-default modules enabled. I also have a test harness where
> I can reproduce these. What additional information would be useful?
> 
> On 09/20/2017 01:05 AM, Ralph Dolmans via Unbound-users wrote:
>> Hi Ales,
>>
>> Thanks for reporting. Do you have any non-default module enabled
>> (subnetcache, ipsecmod, respip, ..)?
>>
>> -- Ralph
>>
>> On 20-09-17 08:18, Aleš Rygl via Unbound-users wrote:
>>> Hello,
>>>
>>> While inspecting unbound logs after an upgrade to Unbound 1.6.0-3+deb9u1 I have found some errors like this:
>>>
>>> Sep 19 12:40:45 unbound[16337:22] error: internal error: looping module stopped
>>> Sep 19 12:40:45 unbound[16337:22] error: internal error: looping module stopped
>>> Sep 19 12:41:00 unbound[16337:21] error: internal error: looping module stopped
>>> Sep 19 12:41:00 unbound[16337:21] error: internal error: looping module stopped
>>> Sep 19 12:41:01 unbound[16337:4] error: internal error: looping module stopped
>>> Sep 19 12:41:01 unbound[16337:4] error: internal error: looping module stopped
>>> Sep 19 12:41:46 unbound[16337:2e] error: internal error: looping module stopped
>>> Sep 19 12:41:46 unbound[16337:2e] error: internal error: looping module stopped
>>> Sep 19 12:42:32 unbound[16337:29] error: internal error: looping module stopped
>>> Sep 19 12:42:32 unbound[16337:29] error: internal error: looping module stopped
>>> Sep 19 12:43:11 unbound[16337:2a] error: internal error: looping module stopped
>>> Sep 19 12:43:11 unbound[16337:2a] error: internal error: looping module stopped
>>>
>>> I have six instances of Unbound and I can see it on all of them. The load is up to 500qps, DNSSEC enabled, use-caps-for-id enabled, IPv6. 
>>>
>>> Thanks
>>>
>>> With regards
>>> Ales
>>>