[Unbound-users] RCODE metrics patch

[Raftery, James]

Hi,

Wouter; thanks for applying the patch!


On 12 Nov 2014, at 20:22, A. Schulze <sca at andreasschulze.de> wrote:
> could you describe the problem your patch solve?

Without it unbound-control omits num.answer.rcode.<something> metrics when they're zero. So you get this:

num.answer.rcode.NOERROR=93
num.answer.rcode.NXDOMAIN=50
num.answer.rcode.nodata=24

instead of this:

num.answer.rcode.NOERROR=93
num.answer.rcode.FORMERR=0
num.answer.rcode.SERVFAIL=0
num.answer.rcode.NXDOMAIN=50
num.answer.rcode.NOTIMPL=0
num.answer.rcode.REFUSED=0
num.answer.rcode.nodata=24

If you've a metrics system that knows the difference between 'absent' and 'zero' this is troublesome. Rather than definitive metric points at zero telling you everything's working well you have potentially long gaps in data points which can mistakenly be interpreted as a fault in the metrics gathering/publishing systems.



james
-- 
James Raftery
Amazon.com Infrastructure DNS



Amazon Data Services Ireland Limited registered office: One Burlington Plaza, Burlington Road, Dublin 4, Ireland. Registered in Ireland. Registration number 390566.