[Unbound-users] [pabs at debian.org: Bug#656549: unbound: please support /etc/unbound/unbound.conf.d dir]

[Paul Wouters]

On Sun, 27 May 2012, Robert Edmonds wrote:

> this sounds like a nice feature to have that could be implemented if the
> "include" directive could take glob() expressions and load multiple
> files.  e.g., we could ship an empty /etc/unbound/conf.d directory in
> the debian package and an "include: /etc/unbound/conf.d/*.conf" line in
> the default debian conf file.

Agreed. Fedora has had attached patch in use since unbound-1.2 to not
error out when a wildcard returns no match for trusted keys, but it
would be nice if that could be generalised over the unbound configuration
reading.

Paul

> ----- Forwarded message from Paul Wise <pabs at debian.org> -----
>
> Date: Fri, 20 Jan 2012 10:01:14 +0800
> From: Paul Wise <pabs at debian.org>
> To: bts <submit at bugs.debian.org>
> Subject: Bug#656549: unbound: please support /etc/unbound/unbound.conf.d dir
> Reply-To: Paul Wise <pabs at debian.org>, 656549 at bugs.debian.org
>
> Package: unbound
> Severity: wishlist
>
> Please add support for an /etc/unbound/unbound.conf.d dir with files
> named *.conf. I need to add some configuration on various machines and I
> would like to be able to drop in the configs using a configuration
> package.
>
> -- 
> bye,
> pabs
>
> http://wiki.debian.org/PaulWise
>
> ----- End forwarded message -----
>
> -- 
> Robert Edmonds
> edmonds at debian.org
> _______________________________________________
> Unbound-users mailing list
> Unbound-users at unbound.net
> http://unbound.nlnetlabs.nl/mailman/listinfo/unbound-users
>
-------------- next part --------------
diff -Naur unbound-1.2.0/validator/val_anchor.c unbound-1.2.0.new/validator/val_anchor.c
--- unbound-1.2.0/validator/val_anchor.c	2009-01-07 07:24:34.000000000 -0500
+++ unbound-1.2.0.new/validator/val_anchor.c	2009-01-20 17:31:43.000000000 -0500
@@ -718,7 +718,8 @@
 			log_err("wildcard trusted-keys-file %s: expansion "
 				"failed (%s)", pat, strerror(errno));
 		}
-		return 0;
+		/* ignore globs that yield no files */
+		return 1;
 	}
 	/* process files found, if any */
 	for(i=0; i<(size_t)g.gl_pathc; i++) {