[nsd-users] Patch: multi-master-check

[manabu-s at iij.ad.jp]

Hi Wouter,

Thank you merge the patch.
but I found a mistake that not tried full zone transfer for a expired zone.

this problem patch is below

xfrd.c
-               if(zone->multi_master_first_master == zone->master_num && zone->round_num > 0) {
+              if(zone->multi_master_first_master == zone->master_num && zone->round_num > 0 && zone->state != xfrd_zone_expired) {


Best regards,
Manabu Sonoda


On 2016/08/05 20:24
W.C.A. Wijngaards <wouter at nlnetlabs.nl> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> Hi Manabu,
> 
> On 05/08/16 08:07, manabu-s at iij.ad.jp wrote:
> > Hi,
> > 
> > I wrote a patch to try transfer from all masters when use multi
> > masters for slave zone.
> 
> Thank you for the patch!  I have incorporated it into the codebase.
> 
> Small changes I made to the patch: I removed the configure time
> option.  I kept the #else part in line 286 of the patch (about 1860 in
> xfrd.c) to keep non-multi-master-checks the same.
> 
> The 4.1.11 release is in RC stage, so this feature has to wait for a
> later software release.
> 
> Best regards, Wouter
> 
> > 
> > https://gist.github.com/mimuret/e68b57561dc76214555c0d9718e9ce4d
> > 
> > If master servers are not synchronise master zone, Sometime, slave
> > zone not updated max serial zone.
> > 
> > For example: Slave:      serial 100 Master1: serial 200 Master2:
> > serial 300
> > 
> > First time, slave tries transfer from Master1, Slave update serial
> > 200, and not try Master2.
> > 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> 
> iQIcBAEBCAAGBQJXpHdVAAoJEJ9vHC1+BF+NjoQP+QFdyxbnLNemb9YyyMpsTGLf
> CqTg90Nxwo2I1KkY0PHHLedresTH8aTaM45MbqSI1Cw10s2PGQI+qHwetRnYCLbv
> uoojXrCvNTCupWJbRyN/+05NG4Hf7DT2NmlQVkMidjCP00mEUlTrqnkbOTbB5jKF
> j6wpmih5o+IihFeqsw1RX75Rd0NYLAFV4c5JPSpAFL0FZlQxOM6eCi3WLdrQW53j
> cMNzxE8rs2sYsA4J4ga0tzqWDBQYxEDW1WDYPHOykdo2hVfv14LBmdOYxJLtB6FN
> Sxu1FvZG3kmhwPJYqSgmto9fahOBB9wfDzCtIUA9nD2cnnHviSAcl1w1biXv2YbG
> T1TmpDQ+2k9MX+aKVgLypoci+UuV3v8qKxiLuDC3bopqWvWzm/uzDx11wql16hr5
> bxqCMilF6EQy/Gn1z4LIKrfs3BKvw3+EzodpnSc8hqcHurMLtRWzb30VjNujuaE1
> fM2bMYGrYFlqGhJEk8In0VwvOLjxh5DBUHjMBrslmORW3tbf1hphL0GgyHEtKi3U
> tNj6fUO5LNvnYluC3Qymw/TfIGHd7qZ1YCFR0vusHURQXDU3oCWbFsz1FjY1Or07
> Hx2Gq31qAC03UakNXYwDOnWzsBFvqRoiPgut0+7KSxkE8G/VHZA06zLmPMEhazW7
> YYOwQJpx9XMyNgWZtjeD
> =qVCr
> -----END PGP SIGNATURE-----
> _______________________________________________
> nsd-users mailing list
> nsd-users at NLnetLabs.nl
> https://open.nlnetlabs.nl/mailman/listinfo/nsd-users
> 


-- 
Manabu Sonoda <manabu-s at iij.ad.jp>
Internet Initiative Japan Inc.