[nsd-users] NSD 4.1.11

[W.C.A. Wijngaards]

Hi Andreas,

On 09/08/16 14:30, A. Schulze wrote:
> 
> W.C.A. Wijngaards:
> 
>> NSD 4.1.11 is available
> 
> I'm a litte bit to late, just started yesterday playing with rc2 :-/
> 
> beside "thanks for nsd", some notes:
> 
> 1. a typo
> xfrd.c, line 1995: "transfered" should be written "transferred"

Fixed.

> 
> 2. comiler warnings:

I fixed most : the strtol, write and xfrd.c/xfrd-disk.c warnings.  These
fixes are in the code repository (not in 4.1.11).

The warnings in configlexer.c and zlexer.c are in the output of the
'flex' tool.  https://sourceforge.net/p/flex/bugs/140/
Perhaps an upgrade of flex can solve the problem?

Best regards, Wouter

> 
> **** Debian Jessie, i386
> gcc -D_FORTIFY_SOURCE=2 -I. -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -W -Wall -Wextra
> -Wdeclaration-after-statement -c configlexer.c
> <stdout>: In function 'c__get_next_buffer':
> <stdout>:1490:18: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
> <stdout>:2427:3: note: in expansion of macro 'YY_INPUT'
> <stdout>:2435:23: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
> 
> gcc -D_FORTIFY_SOURCE=2 -I. -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -W -Wall -Wextra
> -Wdeclaration-after-statement -c xfrd-disk.c
> xfrd-disk.c: In function 'xfrd_read_state':
> xfrd-disk.c:270:19: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>    if (soa_refresh > zone->zone_options->pattern->max_refresh_time)
>                    ^
> xfrd-disk.c:272:24: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>    else if (soa_refresh < zone->zone_options->pattern->min_refresh_time)
>                         ^
> xfrd-disk.c:277:5: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>      > soa_refresh))
>      ^
> 
> gcc -D_FORTIFY_SOURCE=2 -I. -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -W -Wall -Wextra
> -Wdeclaration-after-statement -c xfrd.c
> xfrd.c: In function 'xfrd_set_timer_refresh':
> xfrd.c:706:18: warning: comparison between signed and unsigned integer
> expressions [-Wsign-compare]
>   if (set_refresh > zone->zone_options->pattern->max_refresh_time)
>                   ^
> xfrd.c:708:23: warning: comparison between signed and unsigned integer
> expressions [-Wsign-compare]
>   else if (set_refresh < zone->zone_options->pattern->min_refresh_time)
>                        ^
> xfrd.c: In function 'xfrd_set_timer_retry':
> xfrd.c:753:16: warning: comparison between signed and unsigned integer
> expressions [-Wsign-compare]
>    if(set_retry > zone->zone_options->pattern->max_retry_time)
>                 ^
> xfrd.c:755:21: warning: comparison between signed and unsigned integer
> expressions [-Wsign-compare]
>    else if(set_retry < zone->zone_options->pattern->min_retry_time)
>                      ^
> gcc -D_FORTIFY_SOURCE=2 -I. -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -W -Wall -Wextra
> -Wdeclaration-after-statement -c ipc.c
> ipc.c: In function 'child_handle_parent_command':
> ipc.c:85:3: warning: ignoring return value of 'write', declared with
> attribute warn_unused_result [-Wunused-result]
>    (void)write(fd, &mode, sizeof(mode));
>    ^
> 
> **** Debian Jessie, amd64
> gcc -D_FORTIFY_SOURCE=2 -I. -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -W -Wall -Wextra
> -Wdeclaration-after-statement -c configlexer.c
> <stdout>: In function 'c__get_next_buffer':
> <stdout>:1490:18: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
> <stdout>:2427:3: note: in expansion of macro 'YY_INPUT'
> <stdout>:2435:23: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
> 
> gcc -D_FORTIFY_SOURCE=2 -I. -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -W -Wall -Wextra
> -Wdeclaration-after-statement -c ipc.c
> ipc.c: In function 'child_handle_parent_command':
> ipc.c:85:3: warning: ignoring return value of 'write', declared with
> attribute warn_unused_result [-Wunused-result]
>    (void)write(fd, &mode, sizeof(mode));
>    ^
> 
> gcc -D_FORTIFY_SOURCE=2 -I. -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -W -Wall -Wextra
> -Wdeclaration-after-statement -c zlexer.c
> <stdout>: In function 'yy_get_next_buffer':
> <stdout>:760:18: warning: comparison between signed and unsigned integer
> expressions [-Wsign-compare]
> <stdout>:1466:3: note: in expansion of macro 'YY_INPUT'
> <stdout>:1474:23: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
> 
> **** SLES11, i586
> gcc -I. -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
> -fasynchronous-unwind-tables -g -W -Wall -Wextra
> -Wdeclaration-after-statement -c configlexer.c
> <stdout>: In function 'c__get_next_buffer':
> <stdout>:2427: warning: comparison between signed and unsigned
> <stdout>:2435: warning: comparison between signed and unsigned
> 
> gcc -I. -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
> -fasynchronous-unwind-tables -g -W -Wall -Wextra
> -Wdeclaration-after-statement -c xfrd-disk.c
> xfrd-disk.c: In function 'xfrd_read_state':
> xfrd-disk.c:270: warning: comparison between signed and unsigned
> xfrd-disk.c:272: warning: comparison between signed and unsigned
> xfrd-disk.c:277: warning: comparison between signed and unsigned
> 
> gcc -I. -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
> -fasynchronous-unwind-tables -g -W -Wall -Wextra
> -Wdeclaration-after-statement -c xfrd.c
> xfrd.c: In function 'xfrd_set_timer_refresh':
> xfrd.c:706: warning: comparison between signed and unsigned
> xfrd.c:708: warning: comparison between signed and unsigned
> xfrd.c: In function 'xfrd_set_timer_retry':
> xfrd.c:753: warning: comparison between signed and unsigned
> xfrd.c:755: warning: comparison between signed and unsigned
> 
> gcc -I. -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
> -fasynchronous-unwind-tables -g -W -Wall -Wextra
> -Wdeclaration-after-statement -c ipc.c
> ipc.c: In function 'child_handle_parent_command':
> ipc.c:85: warning: ignoring return value of 'write', declared with
> attribute warn_unused_result
> 
> gcc -I. -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
> -fasynchronous-unwind-tables -g -W -Wall -Wextra
> -Wdeclaration-after-statement -c zlexer.c
> <stdout>: In function 'yy_get_next_buffer':
> <stdout>:1466: warning: comparison between signed and unsigned
> <stdout>:1474: warning: comparison between signed and unsigned
> 
> gcc -I. -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
> -fasynchronous-unwind-tables -g -W -Wall -Wextra
> -Wdeclaration-after-statement -c zonec.c
> zonec.c: In function 'zparser_conv_loc':
> zonec.c:956: warning: ignoring return value of 'strtol', declared with
> attribute warn_unused_result
> 
> *** SLES11, x86_64
> gcc -I. -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2
> -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -W
> -Wall -Wextra -Wdeclaration-after-statement -c configlexer.c
> <stdout>: In function 'c__get_next_buffer':
> <stdout>:2427: warning: comparison between signed and unsigned
> <stdout>:2435: warning: comparison between signed and unsigned
> 
> gcc -I. -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2
> -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -W
> -Wall -Wextra -Wdeclaration-after-statement -c ipc.c
> ipc.c: In function 'child_handle_parent_command':
> ipc.c:85: warning: ignoring return value of 'write', declared with
> attribute warn_unused_result
> 
> gcc -I. -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2
> -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -W
> -Wall -Wextra -Wdeclaration-after-statement -c zlexer.c
> <stdout>: In function 'yy_get_next_buffer':
> <stdout>:1466: warning: comparison between signed and unsigned
> <stdout>:1474: warning: comparison between signed and unsigned
> 
> gcc -I. -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2
> -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -W
> -Wall -Wextra -Wdeclaration-after-statement -c zonec.c
> zonec.c: In function 'zparser_conv_loc':
> zonec.c:956: warning: ignoring return value of 'strtol', declared with
> attribute warn_unused_result
> 
> Andreas
> 
> _______________________________________________
> nsd-users mailing list
> nsd-users at NLnetLabs.nl
> https://open.nlnetlabs.nl/mailman/listinfo/nsd-users


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.nlnetlabs.nl/pipermail/nsd-users/attachments/20160809/74246269/attachment.bin>