From kal at securenic.net Thu May 22 12:09:04 2014 From: kal at securenic.net (Kal Feher) Date: Thu, 22 May 2014 22:09:04 +1000 Subject: [ldns-users] validating nsec responses with drill Message-ID: <68D90F0A-A381-4935-823A-88CB083DE224@securenic.net> Hello list, I?ve been trying to get to the bottom of some odd behaviour with drill. The behaviour I?m seeing appears to be limited to verifying nsec responses. When issuing the following query: drill -a -4 -V 5 -d us -k uskey -TD 0.us I receive the following response (trimmed for clarity): ;; AUTHORITY SECTION: us. 900 IN SOA a.cctld.us. hostmaster.neustar.biz. 2011722984 900 900 604800 86400 us. 900 IN RRSIG SOA 5 1 900 20140621111356 20140522101356 28350 US. C44LuFw7+/QekEvR US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 us. 86400 IN RRSIG NSEC 5 1 86400 20140617202559 20140518200713 28350 US. SjkrioUZ4T ;; Existence of data set with this name denied by NSEC NSEC(3) Records to verify: US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 With signatures: correct keys: us. 518400 IN DNSKEY 257 3 5 AwEAAcPLfBcYsSxr3IQFL;{id = 44323 (ksk), size = 2048b} us. 518400 IN DNSKEY 257 3 5 AwEAAatM9tlDcd8gpSq+ ;{id = 55408 (ksk), size = 2048b} us. 518400 IN DNSKEY 256 3 5 AwEAAZxMuH84tkVwYuP;{id = 14358 (zsk), size = 1024b} us. 518400 IN DNSKEY 256 3 5 AwEAAZ6LjDKPJisyM73 ;{id = 28350 (zsk), size = 1024b} [B] Error verifying denial of existence for 0.us. type A: No DNSSEC signature(s) ;;[S] self sig OK; [B] bogus; [T] trusted Yet when I query for another non existent label: drill -a -4 -V 5 -d us -k uskey -TD 0-000.us I have succes: ;; AUTHORITY SECTION: us. 900 IN SOA a.cctld.us. hostmaster.neustar.biz. 2011722996 900 900 604800 86400 us. 900 IN RRSIG SOA 5 1 900 20140621111552 20140522101552 28350 US. CKhVuRK1BsCBZw8ydZ45CiEz7 US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 us. 86400 IN RRSIG NSEC 5 1 86400 20140617202559 20140518200713 28350 US. SjkrioUZ4TauR5c7OGhGXy 0-00.US. 86400 IN NSEC 0-0000AKLUJVHZ.us. NS RRSIG NSEC 0-00.US. 86400 IN RRSIG NSEC 5 2 86400 20140613022320 20140514021623 28350 US. Q2ixTZVctcc2pD0WgMtL7 NSEC(3) Records to verify: 0-00.US. 86400 IN NSEC 0-0000AKLUJVHZ.us. NS RRSIG NSEC With signatures: 0-00.US. 86400 IN RRSIG NSEC 5 2 86400 20140613022320 20140514021623 28350 US. Q2ixTZVctcc2pD0WgMtL7 correct keys: us. 518400 IN DNSKEY 257 3 5 AwEAAcPLfBcYsSxr3IQFLeJraBpgwzHqd ;{id = 44323 (ksk), size = 2048b} us. 518400 IN DNSKEY 256 3 5 AwEAAZxMuH84tkVwYuPk7+QDPQuq9 ;{id = 14358 (zsk), size = 1024b} us. 518400 IN DNSKEY 256 3 5 AwEAAZ6LjDKPJisyM730QN6miz2cQCW ;{id = 28350 (zsk), size = 1024b} us. 518400 IN DNSKEY 257 3 5 AwEAAatM9tlDcd8gpSq+Wlksu;{id = 55408 (ksk), size = 2048b} [T] Existence denied: 0-000.us. A ;;[S] self sig OK; [B] bogus; [T] trusted The signatures look fine, but for some reason they do not appear in the output for my first test above. This results in an error (RR count less than 1). Is it the case of the label (upper for NSEC, lower for its RRSIG) that is causing the issue for drill? I?ve flicked through the code going backwards from the error message but only got as far as ldns_verify() before my poor c skills failed me. Am I missing an obvious DNSSEC error that I can?t see? Kal From willem at nlnetlabs.nl Thu May 22 12:33:54 2014 From: willem at nlnetlabs.nl (Willem Toorop) Date: Thu, 22 May 2014 14:33:54 +0200 Subject: [ldns-users] validating nsec responses with drill In-Reply-To: <68D90F0A-A381-4935-823A-88CB083DE224@securenic.net> References: <68D90F0A-A381-4935-823A-88CB083DE224@securenic.net> Message-ID: <537DEEB2.4060903@nlnetlabs.nl> Hi Kal, Which version of drill do you use. My drill 1.6.17 gives trusted existence denied for 0.us: $ drill -a -4 -d us -k uskey -TD 0.us ;; Number of trusted keys: 4 ;; Domain: us. [T] us. 518400 IN DNSKEY 257 3 5 ;{id = 55408 (ksk), size = 2048b} us. 518400 IN DNSKEY 256 3 5 ;{id = 14358 (zsk), size = 1024b} us. 518400 IN DNSKEY 257 3 5 ;{id = 44323 (ksk), size = 2048b} us. 518400 IN DNSKEY 256 3 5 ;{id = 28350 (zsk), size = 1024b} [T] Existence denied: 0.us. DS ;; No ds record for delegation ;; Domain: 0.us. ;; No DNSKEY record found for 0.us. [T] Existence denied: 0.us. A ;;[S] self sig OK; [B] bogus; [T] trusted op 22-05-14 14:09, Kal Feher schreef: > Hello list, > I?ve been trying to get to the bottom of some odd behaviour with drill. > The behaviour I?m seeing appears to be limited to verifying nsec responses. When issuing the following query: > drill -a -4 -V 5 -d us -k uskey -TD 0.us > I receive the following response (trimmed for clarity): > > ;; AUTHORITY SECTION: > us. 900 IN SOA a.cctld.us. hostmaster.neustar.biz. 2011722984 900 900 604800 86400 > us. 900 IN RRSIG SOA 5 1 900 20140621111356 20140522101356 28350 US. C44LuFw7+/QekEvR > US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 > us. 86400 IN RRSIG NSEC 5 1 86400 20140617202559 20140518200713 28350 US. SjkrioUZ4T > > ;; Existence of data set with this name denied by NSEC > NSEC(3) Records to verify: > US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 > With signatures: > correct keys: > us. 518400 IN DNSKEY 257 3 5 AwEAAcPLfBcYsSxr3IQFL;{id = 44323 (ksk), size = 2048b} > us. 518400 IN DNSKEY 257 3 5 AwEAAatM9tlDcd8gpSq+ ;{id = 55408 (ksk), size = 2048b} > us. 518400 IN DNSKEY 256 3 5 AwEAAZxMuH84tkVwYuP;{id = 14358 (zsk), size = 1024b} > us. 518400 IN DNSKEY 256 3 5 AwEAAZ6LjDKPJisyM73 ;{id = 28350 (zsk), size = 1024b} > [B] Error verifying denial of existence for 0.us. type A: No DNSSEC signature(s) > ;;[S] self sig OK; [B] bogus; [T] trusted > > > Yet when I query for another non existent label: > drill -a -4 -V 5 -d us -k uskey -TD 0-000.us > I have succes: > > ;; AUTHORITY SECTION: > us. 900 IN SOA a.cctld.us. hostmaster.neustar.biz. 2011722996 900 900 604800 86400 > us. 900 IN RRSIG SOA 5 1 900 20140621111552 20140522101552 28350 US. CKhVuRK1BsCBZw8ydZ45CiEz7 > US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 > us. 86400 IN RRSIG NSEC 5 1 86400 20140617202559 20140518200713 28350 US. SjkrioUZ4TauR5c7OGhGXy > 0-00.US. 86400 IN NSEC 0-0000AKLUJVHZ.us. NS RRSIG NSEC > 0-00.US. 86400 IN RRSIG NSEC 5 2 86400 20140613022320 20140514021623 28350 US. Q2ixTZVctcc2pD0WgMtL7 > > NSEC(3) Records to verify: > 0-00.US. 86400 IN NSEC 0-0000AKLUJVHZ.us. NS RRSIG NSEC > With signatures: > 0-00.US. 86400 IN RRSIG NSEC 5 2 86400 20140613022320 20140514021623 28350 US. Q2ixTZVctcc2pD0WgMtL7 > correct keys: > us. 518400 IN DNSKEY 257 3 5 AwEAAcPLfBcYsSxr3IQFLeJraBpgwzHqd ;{id = 44323 (ksk), size = 2048b} > us. 518400 IN DNSKEY 256 3 5 AwEAAZxMuH84tkVwYuPk7+QDPQuq9 ;{id = 14358 (zsk), size = 1024b} > us. 518400 IN DNSKEY 256 3 5 AwEAAZ6LjDKPJisyM730QN6miz2cQCW ;{id = 28350 (zsk), size = 1024b} > us. 518400 IN DNSKEY 257 3 5 AwEAAatM9tlDcd8gpSq+Wlksu;{id = 55408 (ksk), size = 2048b} > [T] Existence denied: 0-000.us. A > ;;[S] self sig OK; [B] bogus; [T] trusted > > The signatures look fine, but for some reason they do not appear in the output for my first test above. This results in an error (RR count less than 1). Is it the case of the label (upper for NSEC, lower for its RRSIG) that is causing the issue for drill? I?ve flicked through the code going backwards from the error message but only got as far as ldns_verify() before my poor c skills failed me. > Am I missing an obvious DNSSEC error that I can?t see? > > Kal > > > > > > > > _______________________________________________ > ldns-users mailing list > ldns-users at open.nlnetlabs.nl > http://open.nlnetlabs.nl/mailman/listinfo/ldns-users > From kal at securenic.net Thu May 22 12:52:38 2014 From: kal at securenic.net (Kal Feher) Date: Thu, 22 May 2014 22:52:38 +1000 Subject: [ldns-users] validating nsec responses with drill In-Reply-To: <537DEEB2.4060903@nlnetlabs.nl> References: <68D90F0A-A381-4935-823A-88CB083DE224@securenic.net> <537DEEB2.4060903@nlnetlabs.nl> Message-ID: <47C386E9-3967-40C6-A3F5-D33EF9B7C3AB@securenic.net> ack. meant to send this to the list. I?m using: drill version 1.6.16 (ldns version 1.6.16), which is the latest package for my distro (Gentoo). I?ll compile the latest version from source and see what happens. On 22 May 2014, at 10:33 pm, Willem Toorop wrote: > Hi Kal, > > Which version of drill do you use. My drill 1.6.17 gives trusted > existence denied for 0.us: > > $ drill -a -4 -d us -k uskey -TD 0.us > ;; Number of trusted keys: 4 > ;; Domain: us. > [T] us. 518400 IN DNSKEY 257 3 5 ;{id = 55408 (ksk), size = 2048b} > us. 518400 IN DNSKEY 256 3 5 ;{id = 14358 (zsk), size = 1024b} > us. 518400 IN DNSKEY 257 3 5 ;{id = 44323 (ksk), size = 2048b} > us. 518400 IN DNSKEY 256 3 5 ;{id = 28350 (zsk), size = 1024b} > [T] Existence denied: 0.us. DS > ;; No ds record for delegation > ;; Domain: 0.us. > ;; No DNSKEY record found for 0.us. > [T] Existence denied: 0.us. A > ;;[S] self sig OK; [B] bogus; [T] trusted > > > op 22-05-14 14:09, Kal Feher schreef: >> Hello list, >> I?ve been trying to get to the bottom of some odd behaviour with drill. >> The behaviour I?m seeing appears to be limited to verifying nsec responses. When issuing the following query: >> drill -a -4 -V 5 -d us -k uskey -TD 0.us >> I receive the following response (trimmed for clarity): >> >> ;; AUTHORITY SECTION: >> us. 900 IN SOA a.cctld.us. hostmaster.neustar.biz. 2011722984 900 900 604800 86400 >> us. 900 IN RRSIG SOA 5 1 900 20140621111356 20140522101356 28350 US. C44LuFw7+/QekEvR >> US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 >> us. 86400 IN RRSIG NSEC 5 1 86400 20140617202559 20140518200713 28350 US. SjkrioUZ4T >> >> ;; Existence of data set with this name denied by NSEC >> NSEC(3) Records to verify: >> US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 >> With signatures: >> correct keys: >> us. 518400 IN DNSKEY 257 3 5 AwEAAcPLfBcYsSxr3IQFL;{id = 44323 (ksk), size = 2048b} >> us. 518400 IN DNSKEY 257 3 5 AwEAAatM9tlDcd8gpSq+ ;{id = 55408 (ksk), size = 2048b} >> us. 518400 IN DNSKEY 256 3 5 AwEAAZxMuH84tkVwYuP;{id = 14358 (zsk), size = 1024b} >> us. 518400 IN DNSKEY 256 3 5 AwEAAZ6LjDKPJisyM73 ;{id = 28350 (zsk), size = 1024b} >> [B] Error verifying denial of existence for 0.us. type A: No DNSSEC signature(s) >> ;;[S] self sig OK; [B] bogus; [T] trusted >> >> >> Yet when I query for another non existent label: >> drill -a -4 -V 5 -d us -k uskey -TD 0-000.us >> I have succes: >> >> ;; AUTHORITY SECTION: >> us. 900 IN SOA a.cctld.us. hostmaster.neustar.biz. 2011722996 900 900 604800 86400 >> us. 900 IN RRSIG SOA 5 1 900 20140621111552 20140522101552 28350 US. CKhVuRK1BsCBZw8ydZ45CiEz7 >> US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 >> us. 86400 IN RRSIG NSEC 5 1 86400 20140617202559 20140518200713 28350 US. SjkrioUZ4TauR5c7OGhGXy >> 0-00.US. 86400 IN NSEC 0-0000AKLUJVHZ.us. NS RRSIG NSEC >> 0-00.US. 86400 IN RRSIG NSEC 5 2 86400 20140613022320 20140514021623 28350 US. Q2ixTZVctcc2pD0WgMtL7 >> >> NSEC(3) Records to verify: >> 0-00.US. 86400 IN NSEC 0-0000AKLUJVHZ.us. NS RRSIG NSEC >> With signatures: >> 0-00.US. 86400 IN RRSIG NSEC 5 2 86400 20140613022320 20140514021623 28350 US. Q2ixTZVctcc2pD0WgMtL7 >> correct keys: >> us. 518400 IN DNSKEY 257 3 5 AwEAAcPLfBcYsSxr3IQFLeJraBpgwzHqd ;{id = 44323 (ksk), size = 2048b} >> us. 518400 IN DNSKEY 256 3 5 AwEAAZxMuH84tkVwYuPk7+QDPQuq9 ;{id = 14358 (zsk), size = 1024b} >> us. 518400 IN DNSKEY 256 3 5 AwEAAZ6LjDKPJisyM730QN6miz2cQCW ;{id = 28350 (zsk), size = 1024b} >> us. 518400 IN DNSKEY 257 3 5 AwEAAatM9tlDcd8gpSq+Wlksu;{id = 55408 (ksk), size = 2048b} >> [T] Existence denied: 0-000.us. A >> ;;[S] self sig OK; [B] bogus; [T] trusted >> >> The signatures look fine, but for some reason they do not appear in the output for my first test above. This results in an error (RR count less than 1). Is it the case of the label (upper for NSEC, lower for its RRSIG) that is causing the issue for drill? I?ve flicked through the code going backwards from the error message but only got as far as ldns_verify() before my poor c skills failed me. >> Am I missing an obvious DNSSEC error that I can?t see? >> >> Kal >> >> >> >> >> >> >> >> _______________________________________________ >> ldns-users mailing list >> ldns-users at open.nlnetlabs.nl >> http://open.nlnetlabs.nl/mailman/listinfo/ldns-users >> > > _______________________________________________ > ldns-users mailing list > ldns-users at open.nlnetlabs.nl > http://open.nlnetlabs.nl/mailman/listinfo/ldns-users From kal at securenic.net Fri May 23 09:21:27 2014 From: kal at securenic.net (Kal Feher) Date: Fri, 23 May 2014 19:21:27 +1000 Subject: [ldns-users] validating nsec responses with drill In-Reply-To: <47C386E9-3967-40C6-A3F5-D33EF9B7C3AB@securenic.net> References: <68D90F0A-A381-4935-823A-88CB083DE224@securenic.net> <537DEEB2.4060903@nlnetlabs.nl> <47C386E9-3967-40C6-A3F5-D33EF9B7C3AB@securenic.net> Message-ID: <1C7E62D8-6E79-43C3-85EF-A4CE95C0FB2C@securenic.net> 1.6.17 from source worked. thanks. On 22 May 2014, at 10:52 pm, Kal Feher wrote: > ack. meant to send this to the list. > > I?m using: > drill version 1.6.16 (ldns version 1.6.16), which is the latest package for my distro (Gentoo). I?ll compile the latest version from source and see what happens. > > > > On 22 May 2014, at 10:33 pm, Willem Toorop wrote: > >> Hi Kal, >> >> Which version of drill do you use. My drill 1.6.17 gives trusted >> existence denied for 0.us: >> >> $ drill -a -4 -d us -k uskey -TD 0.us >> ;; Number of trusted keys: 4 >> ;; Domain: us. >> [T] us. 518400 IN DNSKEY 257 3 5 ;{id = 55408 (ksk), size = 2048b} >> us. 518400 IN DNSKEY 256 3 5 ;{id = 14358 (zsk), size = 1024b} >> us. 518400 IN DNSKEY 257 3 5 ;{id = 44323 (ksk), size = 2048b} >> us. 518400 IN DNSKEY 256 3 5 ;{id = 28350 (zsk), size = 1024b} >> [T] Existence denied: 0.us. DS >> ;; No ds record for delegation >> ;; Domain: 0.us. >> ;; No DNSKEY record found for 0.us. >> [T] Existence denied: 0.us. A >> ;;[S] self sig OK; [B] bogus; [T] trusted >> >> >> op 22-05-14 14:09, Kal Feher schreef: >>> Hello list, >>> I?ve been trying to get to the bottom of some odd behaviour with drill. >>> The behaviour I?m seeing appears to be limited to verifying nsec responses. When issuing the following query: >>> drill -a -4 -V 5 -d us -k uskey -TD 0.us >>> I receive the following response (trimmed for clarity): >>> >>> ;; AUTHORITY SECTION: >>> us. 900 IN SOA a.cctld.us. hostmaster.neustar.biz. 2011722984 900 900 604800 86400 >>> us. 900 IN RRSIG SOA 5 1 900 20140621111356 20140522101356 28350 US. C44LuFw7+/QekEvR >>> US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 >>> us. 86400 IN RRSIG NSEC 5 1 86400 20140617202559 20140518200713 28350 US. SjkrioUZ4T >>> >>> ;; Existence of data set with this name denied by NSEC >>> NSEC(3) Records to verify: >>> US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 >>> With signatures: >>> correct keys: >>> us. 518400 IN DNSKEY 257 3 5 AwEAAcPLfBcYsSxr3IQFL;{id = 44323 (ksk), size = 2048b} >>> us. 518400 IN DNSKEY 257 3 5 AwEAAatM9tlDcd8gpSq+ ;{id = 55408 (ksk), size = 2048b} >>> us. 518400 IN DNSKEY 256 3 5 AwEAAZxMuH84tkVwYuP;{id = 14358 (zsk), size = 1024b} >>> us. 518400 IN DNSKEY 256 3 5 AwEAAZ6LjDKPJisyM73 ;{id = 28350 (zsk), size = 1024b} >>> [B] Error verifying denial of existence for 0.us. type A: No DNSSEC signature(s) >>> ;;[S] self sig OK; [B] bogus; [T] trusted >>> >>> >>> Yet when I query for another non existent label: >>> drill -a -4 -V 5 -d us -k uskey -TD 0-000.us >>> I have succes: >>> >>> ;; AUTHORITY SECTION: >>> us. 900 IN SOA a.cctld.us. hostmaster.neustar.biz. 2011722996 900 900 604800 86400 >>> us. 900 IN RRSIG SOA 5 1 900 20140621111552 20140522101552 28350 US. CKhVuRK1BsCBZw8ydZ45CiEz7 >>> US. 86400 IN NSEC 0-.us. NS SOA RRSIG NSEC DNSKEY TYPE65534 >>> us. 86400 IN RRSIG NSEC 5 1 86400 20140617202559 20140518200713 28350 US. SjkrioUZ4TauR5c7OGhGXy >>> 0-00.US. 86400 IN NSEC 0-0000AKLUJVHZ.us. NS RRSIG NSEC >>> 0-00.US. 86400 IN RRSIG NSEC 5 2 86400 20140613022320 20140514021623 28350 US. Q2ixTZVctcc2pD0WgMtL7 >>> >>> NSEC(3) Records to verify: >>> 0-00.US. 86400 IN NSEC 0-0000AKLUJVHZ.us. NS RRSIG NSEC >>> With signatures: >>> 0-00.US. 86400 IN RRSIG NSEC 5 2 86400 20140613022320 20140514021623 28350 US. Q2ixTZVctcc2pD0WgMtL7 >>> correct keys: >>> us. 518400 IN DNSKEY 257 3 5 AwEAAcPLfBcYsSxr3IQFLeJraBpgwzHqd ;{id = 44323 (ksk), size = 2048b} >>> us. 518400 IN DNSKEY 256 3 5 AwEAAZxMuH84tkVwYuPk7+QDPQuq9 ;{id = 14358 (zsk), size = 1024b} >>> us. 518400 IN DNSKEY 256 3 5 AwEAAZ6LjDKPJisyM730QN6miz2cQCW ;{id = 28350 (zsk), size = 1024b} >>> us. 518400 IN DNSKEY 257 3 5 AwEAAatM9tlDcd8gpSq+Wlksu;{id = 55408 (ksk), size = 2048b} >>> [T] Existence denied: 0-000.us. A >>> ;;[S] self sig OK; [B] bogus; [T] trusted >>> >>> The signatures look fine, but for some reason they do not appear in the output for my first test above. This results in an error (RR count less than 1). Is it the case of the label (upper for NSEC, lower for its RRSIG) that is causing the issue for drill? I?ve flicked through the code going backwards from the error message but only got as far as ldns_verify() before my poor c skills failed me. >>> Am I missing an obvious DNSSEC error that I can?t see? >>> >>> Kal >>> >>> >>> >>> >>> >>> >>> >>> _______________________________________________ >>> ldns-users mailing list >>> ldns-users at open.nlnetlabs.nl >>> http://open.nlnetlabs.nl/mailman/listinfo/ldns-users >>> >> >> _______________________________________________ >> ldns-users mailing list >> ldns-users at open.nlnetlabs.nl >> http://open.nlnetlabs.nl/mailman/listinfo/ldns-users > > > _______________________________________________ > ldns-users mailing list > ldns-users at open.nlnetlabs.nl > http://open.nlnetlabs.nl/mailman/listinfo/ldns-users From des at des.no Tue May 27 21:52:29 2014 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Tue, 27 May 2014 23:52:29 +0200 Subject: [ldns-users] Code cleanup Message-ID: <86mwe2dh42.fsf@nine.des.no> The attached patch shows the changes I've made to FreeBSD's copy of Unbound, with inline comments, relative to 1.6.17. All of them fix compiler warnings or errors, and I believe they are all suitable for inclusion in the standard distribution. DES -- Dag-Erling Sm?rgrav - des at des.no -------------- next part -------------- A non-text attachment was scrubbed... Name: ldns-freebsd.diff Type: text/x-patch Size: 4035 bytes Desc: not available URL: From willem at nlnetlabs.nl Wed May 28 11:32:15 2014 From: willem at nlnetlabs.nl (Willem Toorop) Date: Wed, 28 May 2014 13:32:15 +0200 Subject: [ldns-users] Code cleanup In-Reply-To: <86mwe2dh42.fsf@nine.des.no> References: <86mwe2dh42.fsf@nine.des.no> Message-ID: <5385C93F.2040206@nlnetlabs.nl> Thanks DES, Patch applied: http://git.nlnetlabs.nl/ldns/commit/?h=develop&id=c0c45a92 -- Willem op 27-05-14 23:52, Dag-Erling Sm?rgrav schreef: > The attached patch shows the changes I've made to FreeBSD's copy of > Unbound, with inline comments, relative to 1.6.17. All of them fix > compiler warnings or errors, and I believe they are all suitable for > inclusion in the standard distribution. > > DES > > > > _______________________________________________ > ldns-users mailing list > ldns-users at open.nlnetlabs.nl > http://open.nlnetlabs.nl/mailman/listinfo/ldns-users >