[ldns-users] Broken code in ldns_pkt_query_new_frm_str

[Michael Sheldon]

Sometime fairly recently, code was added to the
ldns_pkt_query_new_frm_str function to add an SOA record to the
authority section if the query type is IXFR.

Problem is, it's completely broken. This doesn't actually work unless
the SOA serial value is correct for the relevant query. It also broke my
systems, since I was adding a proper SOA to the authority myself, thus
resulting in two SOA in the authority, and a resulting FORMERR from
remote systems.


Michael Sheldon
Dev-DNS Services
GoDaddy.com