[ldns-users] Missing or incorrect prototypes

[Dag-Erling Smørgrav]

Willem Toorop <willem at nlnetlabs.nl> writes:
> Your patches are committed to trunk (Though unstaticized
> ldns_dname_compare_v, because it is used in dnssec_sign too ;).

It still needs a prototype:

Index: ldns/dname.h
===================================================================
--- ldns/dname.h	(revision 3837)
+++ ldns/dname.h	(working copy)
@@ -150,6 +150,7 @@
  * \return -1 if dname1 comes before dname2, 1 if dname1 comes after dname2, and 0 if they are equal.
  */
 int ldns_dname_compare(const ldns_rdf *dname1, const ldns_rdf *dname2);
+int ldns_dname_compare_v(const void *, const void *);
 
 /**
  * Checks whether the dname matches the given wildcard

BTW, including argument names in prototypes is a bad habit - it pollutes
the application namespace.

DES
-- 
Dag-Erling Smørgrav - des at des.no