From psimerda at redhat.com Fri Mar 21 08:47:24 2014 From: psimerda at redhat.com (Pavel Simerda) Date: Fri, 21 Mar 2014 04:47:24 -0400 (EDT) Subject: [Dnssec-trigger] patch: better integration with NetworkManager and distributions In-Reply-To: <1923476184.1813804.1395391311106.JavaMail.zimbra@redhat.com> Message-ID: <1397317559.1814354.1395391644433.JavaMail.zimbra@redhat.com> Hi, I'm sending a patch that improves on former Tom??'s work on NetworkManager integration. I've been using a patched version for a while now, it works pretty well for me. I'm ready to fix any bugs that are discovered by others. Details in the commit message, see attachmenet. Comments welcome. Cheers, Pavel -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-better-integration-with-NetworkManager-and-distribut.patch Type: text/x-patch Size: 22197 bytes Desc: not available URL: From wouter at nlnetlabs.nl Fri Mar 21 15:31:13 2014 From: wouter at nlnetlabs.nl (W.C.A. Wijngaards) Date: Fri, 21 Mar 2014 16:31:13 +0100 Subject: [Dnssec-trigger] patch: better integration with NetworkManager and distributions In-Reply-To: <1397317559.1814354.1395391644433.JavaMail.zimbra@redhat.com> References: <1397317559.1814354.1395391644433.JavaMail.zimbra@redhat.com> Message-ID: <532C5B41.5070405@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Pavel, Should I remove the obsolete files? I mean, also in the opinion of others, or should I leave them for people that want another setup? The bug entry: yes that I'll see about helping with that by implementing a new feature in unbound. Thanks for the hard work and complicated scripts! Best regards, Wouter On 03/21/2014 09:47 AM, Pavel Simerda wrote: > Hi, > > I'm sending a patch that improves on former Tom??'s work on > NetworkManager integration. I've been using a patched version for a > while now, it works pretty well for me. I'm ready to fix any bugs > that are discovered by others. > > Details in the commit message, see attachmenet. Comments welcome. > > Cheers, > > Pavel > > > > _______________________________________________ dnssec-trigger > mailing list dnssec-trigger at NLnetLabs.nl > http://open.nlnetlabs.nl/mailman/listinfo/dnssec-trigger > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTLFtBAAoJEJ9vHC1+BF+NjEwP/2Xllqer1U/NKL+IrS66nh9L Fd5awq3xDk+fQMP/eSm6w266ej6O2jI3SJu8EWyHwKk6m0upIZC9gdDV6kA720Cq HNw37HPG+ltOpRfnHgcmF7DMGCoX/KxLIC0opo4hEddmFIxaLZywi053hVm1j17l kfsemqHHe0Vf4i3bif2ACyCc7EwKJeNFWGub5NoSq/JRQpndU/F1HtdgjeeyBlRl O9OCxEcSmRZSQs73LbBQol8ABe4H2y+Y0lZrUA+vAPVK3O6movBSuA+dt5oj9olQ xys3oz1RijyYW0kwWipfEetRy0/SSV8+cqf0eqIq8xX8XuZ75IP6i5rXWt7FDsRS CZ0sDGxp60OQVp1G9HPkWHX7k2iYbSQQBetkLJwIk6GUO5j0rwTytt3GcFSIFqRW AiuBom+UDaMUsNygD4Etr2UjfhgYhR67lvQnm/Xk+NuSKyk0ffewhe+ti4pm3pvm xzJv8KOTHY5ihQXVmNd2rhoO01mEVfDExZgBJ4GZwrZszdBcQTiBLVlCEmShDPJm H7QWUxqGXVnIdryN/MGYqf0783sH7bocZ9drEE8dgp8Jxx7ycSKh3lq9AyF4zL/1 8qJUsQvxgjzRqY/G6uYsEyTIWMxY2HF8fg1s3gZv46ULHpXI811NF0f6JzZZkGAK FDCCMtW9Blg0cKUBcRwy =isWe -----END PGP SIGNATURE----- From thozza at redhat.com Mon Mar 24 07:31:02 2014 From: thozza at redhat.com (Tomas Hozza) Date: Mon, 24 Mar 2014 03:31:02 -0400 (EDT) Subject: [Dnssec-trigger] patch: better integration with NetworkManager and distributions In-Reply-To: <532C5B41.5070405@nlnetlabs.nl> References: <1397317559.1814354.1395391644433.JavaMail.zimbra@redhat.com> <532C5B41.5070405@nlnetlabs.nl> Message-ID: <1794683297.2226563.1395646262733.JavaMail.zimbra@redhat.com> Hi Wouter. ----- Original Message ----- > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi Pavel, > > Should I remove the obsolete files? I mean, also in the opinion of > others, or should I leave them for people that want another setup? I think the obsolete files can be removed, as the new scripts are doing technically the same (+ some better handling of corner cases). I can not think of a setup where you could do something with the obsolete scripts and couldn't do it with the new ones. Regards, Tomas > The bug entry: yes that I'll see about helping with that by > implementing a new feature in unbound. > > Thanks for the hard work and complicated scripts! > > Best regards, > Wouter > > On 03/21/2014 09:47 AM, Pavel Simerda wrote: > > Hi, > > > > I'm sending a patch that improves on former Tom??'s work on > > NetworkManager integration. I've been using a patched version for a > > while now, it works pretty well for me. I'm ready to fix any bugs > > that are discovered by others. > > > > Details in the commit message, see attachmenet. Comments welcome. > > > > Cheers, > > > > Pavel > > > > > > > > _______________________________________________ dnssec-trigger > > mailing list dnssec-trigger at NLnetLabs.nl > > http://open.nlnetlabs.nl/mailman/listinfo/dnssec-trigger > > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJTLFtBAAoJEJ9vHC1+BF+NjEwP/2Xllqer1U/NKL+IrS66nh9L > Fd5awq3xDk+fQMP/eSm6w266ej6O2jI3SJu8EWyHwKk6m0upIZC9gdDV6kA720Cq > HNw37HPG+ltOpRfnHgcmF7DMGCoX/KxLIC0opo4hEddmFIxaLZywi053hVm1j17l > kfsemqHHe0Vf4i3bif2ACyCc7EwKJeNFWGub5NoSq/JRQpndU/F1HtdgjeeyBlRl > O9OCxEcSmRZSQs73LbBQol8ABe4H2y+Y0lZrUA+vAPVK3O6movBSuA+dt5oj9olQ > xys3oz1RijyYW0kwWipfEetRy0/SSV8+cqf0eqIq8xX8XuZ75IP6i5rXWt7FDsRS > CZ0sDGxp60OQVp1G9HPkWHX7k2iYbSQQBetkLJwIk6GUO5j0rwTytt3GcFSIFqRW > AiuBom+UDaMUsNygD4Etr2UjfhgYhR67lvQnm/Xk+NuSKyk0ffewhe+ti4pm3pvm > xzJv8KOTHY5ihQXVmNd2rhoO01mEVfDExZgBJ4GZwrZszdBcQTiBLVlCEmShDPJm > H7QWUxqGXVnIdryN/MGYqf0783sH7bocZ9drEE8dgp8Jxx7ycSKh3lq9AyF4zL/1 > 8qJUsQvxgjzRqY/G6uYsEyTIWMxY2HF8fg1s3gZv46ULHpXI811NF0f6JzZZkGAK > FDCCMtW9Blg0cKUBcRwy > =isWe > -----END PGP SIGNATURE----- > _______________________________________________ > dnssec-trigger mailing list > dnssec-trigger at NLnetLabs.nl > http://open.nlnetlabs.nl/mailman/listinfo/dnssec-trigger > From psimerda at redhat.com Mon Mar 24 13:51:17 2014 From: psimerda at redhat.com (Pavel Simerda) Date: Mon, 24 Mar 2014 09:51:17 -0400 (EDT) Subject: [Dnssec-trigger] patch: better integration with NetworkManager and distributions In-Reply-To: <1794683297.2226563.1395646262733.JavaMail.zimbra@redhat.com> References: <1397317559.1814354.1395391644433.JavaMail.zimbra@redhat.com> <532C5B41.5070405@nlnetlabs.nl> <1794683297.2226563.1395646262733.JavaMail.zimbra@redhat.com> Message-ID: <1897975448.2363982.1395669077741.JavaMail.zimbra@redhat.com> ----- Original Message ----- > From: "Tomas Hozza" > To: "W.C.A. Wijngaards" > Cc: dnssec-trigger at NLnetLabs.nl, "Pavel Simerda" > Sent: Monday, March 24, 2014 8:31:02 AM > Subject: Re: [Dnssec-trigger] patch: better integration with NetworkManager and distributions > > Hi Wouter. > > ----- Original Message ----- > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Hi Pavel, > > > > Should I remove the obsolete files? I mean, also in the opinion of > > others, or should I leave them for people that want another setup? > > I think the obsolete files can be removed, as the new scripts > are doing technically the same (+ some better handling of corner cases). Sure. > I can not think of a setup where you could do something with the > obsolete scripts and couldn't do it with the new ones. > > > Regards, > > Tomas > > > The bug entry: yes that I'll see about helping with that by > > implementing a new feature in unbound. > > > > Thanks for the hard work and complicated scripts! Thank you! Cheers, Pavel > > > > Best regards, > > Wouter > > > > On 03/21/2014 09:47 AM, Pavel Simerda wrote: > > > Hi, > > > > > > I'm sending a patch that improves on former Tom??'s work on > > > NetworkManager integration. I've been using a patched version for a > > > while now, it works pretty well for me. I'm ready to fix any bugs > > > that are discovered by others. > > > > > > Details in the commit message, see attachmenet. Comments welcome. > > > > > > Cheers, > > > > > > Pavel > > > > > > > > > > > > _______________________________________________ dnssec-trigger > > > mailing list dnssec-trigger at NLnetLabs.nl > > > http://open.nlnetlabs.nl/mailman/listinfo/dnssec-trigger > > > > > > > -----BEGIN PGP SIGNATURE----- > > Version: GnuPG v1 > > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > > > iQIcBAEBAgAGBQJTLFtBAAoJEJ9vHC1+BF+NjEwP/2Xllqer1U/NKL+IrS66nh9L > > Fd5awq3xDk+fQMP/eSm6w266ej6O2jI3SJu8EWyHwKk6m0upIZC9gdDV6kA720Cq > > HNw37HPG+ltOpRfnHgcmF7DMGCoX/KxLIC0opo4hEddmFIxaLZywi053hVm1j17l > > kfsemqHHe0Vf4i3bif2ACyCc7EwKJeNFWGub5NoSq/JRQpndU/F1HtdgjeeyBlRl > > O9OCxEcSmRZSQs73LbBQol8ABe4H2y+Y0lZrUA+vAPVK3O6movBSuA+dt5oj9olQ > > xys3oz1RijyYW0kwWipfEetRy0/SSV8+cqf0eqIq8xX8XuZ75IP6i5rXWt7FDsRS > > CZ0sDGxp60OQVp1G9HPkWHX7k2iYbSQQBetkLJwIk6GUO5j0rwTytt3GcFSIFqRW > > AiuBom+UDaMUsNygD4Etr2UjfhgYhR67lvQnm/Xk+NuSKyk0ffewhe+ti4pm3pvm > > xzJv8KOTHY5ihQXVmNd2rhoO01mEVfDExZgBJ4GZwrZszdBcQTiBLVlCEmShDPJm > > H7QWUxqGXVnIdryN/MGYqf0783sH7bocZ9drEE8dgp8Jxx7ycSKh3lq9AyF4zL/1 > > 8qJUsQvxgjzRqY/G6uYsEyTIWMxY2HF8fg1s3gZv46ULHpXI811NF0f6JzZZkGAK > > FDCCMtW9Blg0cKUBcRwy > > =isWe > > -----END PGP SIGNATURE----- > > _______________________________________________ > > dnssec-trigger mailing list > > dnssec-trigger at NLnetLabs.nl > > http://open.nlnetlabs.nl/mailman/listinfo/dnssec-trigger > > > From psimerda at redhat.com Tue Mar 25 10:55:40 2014 From: psimerda at redhat.com (Pavel Simerda) Date: Tue, 25 Mar 2014 06:55:40 -0400 (EDT) Subject: [Dnssec-trigger] patch: rename 01-dnssec-trigger-hook.sh.in to 01-dnssec-trigger.in In-Reply-To: <1794683297.2226563.1395646262733.JavaMail.zimbra@redhat.com> References: <1397317559.1814354.1395391644433.JavaMail.zimbra@redhat.com> <532C5B41.5070405@nlnetlabs.nl> <1794683297.2226563.1395646262733.JavaMail.zimbra@redhat.com> Message-ID: <339265877.2638965.1395744940125.JavaMail.zimbra@redhat.com> Hi, I'm submitting a patch to rename the dnssec trigger hook. NetworkManager's /etc/NetworkManager/dispatcher.d directory contains dispatcher hooks which are typically named after the service that installs them, qualified by an ordering number. The '-hook' suffix is redundant here, as is the '.sh' suffix in the source tree. Cheers, Pavel ----- Original Message ----- > From: "Tomas Hozza" > To: "W.C.A. Wijngaards" > Cc: dnssec-trigger at NLnetLabs.nl, "Pavel Simerda" > Sent: Monday, March 24, 2014 8:31:02 AM > Subject: Re: [Dnssec-trigger] patch: better integration with NetworkManager and distributions > > Hi Wouter. > > ----- Original Message ----- > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Hi Pavel, > > > > Should I remove the obsolete files? I mean, also in the opinion of > > others, or should I leave them for people that want another setup? > > I think the obsolete files can be removed, as the new scripts > are doing technically the same (+ some better handling of corner cases). > I can not think of a setup where you could do something with the > obsolete scripts and couldn't do it with the new ones. > > > Regards, > > Tomas > > > The bug entry: yes that I'll see about helping with that by > > implementing a new feature in unbound. > > > > Thanks for the hard work and complicated scripts! > > > > Best regards, > > Wouter > > > > On 03/21/2014 09:47 AM, Pavel Simerda wrote: > > > Hi, > > > > > > I'm sending a patch that improves on former Tom??'s work on > > > NetworkManager integration. I've been using a patched version for a > > > while now, it works pretty well for me. I'm ready to fix any bugs > > > that are discovered by others. > > > > > > Details in the commit message, see attachmenet. Comments welcome. > > > > > > Cheers, > > > > > > Pavel > > > > > > > > > > > > _______________________________________________ dnssec-trigger > > > mailing list dnssec-trigger at NLnetLabs.nl > > > http://open.nlnetlabs.nl/mailman/listinfo/dnssec-trigger > > > > > > > -----BEGIN PGP SIGNATURE----- > > Version: GnuPG v1 > > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > > > iQIcBAEBAgAGBQJTLFtBAAoJEJ9vHC1+BF+NjEwP/2Xllqer1U/NKL+IrS66nh9L > > Fd5awq3xDk+fQMP/eSm6w266ej6O2jI3SJu8EWyHwKk6m0upIZC9gdDV6kA720Cq > > HNw37HPG+ltOpRfnHgcmF7DMGCoX/KxLIC0opo4hEddmFIxaLZywi053hVm1j17l > > kfsemqHHe0Vf4i3bif2ACyCc7EwKJeNFWGub5NoSq/JRQpndU/F1HtdgjeeyBlRl > > O9OCxEcSmRZSQs73LbBQol8ABe4H2y+Y0lZrUA+vAPVK3O6movBSuA+dt5oj9olQ > > xys3oz1RijyYW0kwWipfEetRy0/SSV8+cqf0eqIq8xX8XuZ75IP6i5rXWt7FDsRS > > CZ0sDGxp60OQVp1G9HPkWHX7k2iYbSQQBetkLJwIk6GUO5j0rwTytt3GcFSIFqRW > > AiuBom+UDaMUsNygD4Etr2UjfhgYhR67lvQnm/Xk+NuSKyk0ffewhe+ti4pm3pvm > > xzJv8KOTHY5ihQXVmNd2rhoO01mEVfDExZgBJ4GZwrZszdBcQTiBLVlCEmShDPJm > > H7QWUxqGXVnIdryN/MGYqf0783sH7bocZ9drEE8dgp8Jxx7ycSKh3lq9AyF4zL/1 > > 8qJUsQvxgjzRqY/G6uYsEyTIWMxY2HF8fg1s3gZv46ULHpXI811NF0f6JzZZkGAK > > FDCCMtW9Blg0cKUBcRwy > > =isWe > > -----END PGP SIGNATURE----- > > _______________________________________________ > > dnssec-trigger mailing list > > dnssec-trigger at NLnetLabs.nl > > http://open.nlnetlabs.nl/mailman/listinfo/dnssec-trigger > > > -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-rename-01-dnssec-trigger-hook.sh.in-to-01-dnssec-tri.patch Type: text/x-patch Size: 11393 bytes Desc: not available URL: From psimerda at redhat.com Tue Mar 25 12:32:23 2014 From: psimerda at redhat.com (Pavel Simerda) Date: Tue, 25 Mar 2014 08:32:23 -0400 (EDT) Subject: [Dnssec-trigger] patch: merge dnssec trigger hook from contrib In-Reply-To: <1601158157.2659954.1395750374931.JavaMail.zimbra@redhat.com> Message-ID: <529298552.2662196.1395750743244.JavaMail.zimbra@redhat.com> Hi, this patch inserts the dnssec trigger hook located in contrib to the beginning of the original hook. If both the check for dns=unbound in NetworkManager configuration and the check for /usr/libexec/dnssec-trigger fail, the behavior remains unchanged. Cheers, Pavel -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-merge-dnssec-trigger-hook-from-contrib.patch Type: text/x-patch Size: 2249 bytes Desc: not available URL: From psimerda at redhat.com Tue Mar 25 16:04:12 2014 From: psimerda at redhat.com (Pavel Simerda) Date: Tue, 25 Mar 2014 12:04:12 -0400 (EDT) Subject: [Dnssec-trigger] patchset: incorporate stuff from contrib In-Reply-To: <368500743.2752815.1395763404116.JavaMail.zimbra@redhat.com> Message-ID: <527727595.2753410.1395763452635.JavaMail.zimbra@redhat.com> Hi, I'm sending a set of patches that incorporate other stuff from the contrib directory into the main tree and build/install system. The first two patches are pretty much straightforward, while the third causes the systemd files only be installed if when built --with-hooks=networkmanager. The systemd files indeed expect dnssec-trigger-script to exist and run, but this could be easily changed by prefixing the path with '-' meaning that the called script is not required to run and finish successfully and then AC_ARG_WITH(systemdsystemunitdir, ...) could be used with some magic to detect /usr/lib/systemd/system automatically. Looking forward to any opinions. Cheers, Pavel -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-merge-contrib-dnssec-trigger-script-into-the-base-di.patch Type: text/x-patch Size: 33560 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-merge-dnssec.conf.sample-into-the-base-distribution.patch Type: text/x-patch Size: 7461 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-merge-systemd-service-files-from-compat.patch Type: text/x-patch Size: 4332 bytes Desc: not available URL: From wouter at nlnetlabs.nl Fri Mar 28 09:31:26 2014 From: wouter at nlnetlabs.nl (W.C.A. Wijngaards) Date: Fri, 28 Mar 2014 10:31:26 +0100 Subject: [Dnssec-trigger] patchset: incorporate stuff from contrib In-Reply-To: <527727595.2753410.1395763452635.JavaMail.zimbra@redhat.com> References: <527727595.2753410.1395763452635.JavaMail.zimbra@redhat.com> Message-ID: <5335416E.4040309@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Pavel, On 03/25/2014 05:04 PM, Pavel Simerda wrote: > Hi, > > I'm sending a set of patches that incorporate other stuff from the > contrib directory into the main tree and build/install system. The > first two patches are pretty much straightforward, while the third > causes the systemd files only be installed if when built > --with-hooks=networkmanager. > > The systemd files indeed expect dnssec-trigger-script to exist and > run, but this could be easily changed by prefixing the path with > '-' meaning that the called script is not required to run and > finish successfully and then AC_ARG_WITH(systemdsystemunitdir, > ...) could be used with some magic to detect > /usr/lib/systemd/system automatically. Looking forward to any > opinions. Thanks for all these patches. I applied this one, but changed a bit. I added install -d that creates the directory, so that the install always succeeds. You need that anyway, so that when you build an rpm against an empty destdir the install will succeed. The configure logic to optionally not-install systemd when systemd is not present is optional; the files are harmless I think if systemd is not there. Best regards, Wouter -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTNUFtAAoJEJ9vHC1+BF+NCCgP/04h0Q4VslNHLreRgx71eInX NuGGkPiwpXSNbTVXf3BS0d4sFZTq854qjidz+m8eaYjtY02Lf5UAgkJ4wOkzBguf EE98YGBj2FJtHhv+Fe5tOxDInVdmtEwv0+WCcAbdAruFs+E78XZ1M/twF6HajeXC MGQNztWXm11NQ7kQ/dgFomRpNA4LHTlg5LOZT0ipXFpLGW5u4Ct3PuM6C3DCL1Wo RDoFH222rJkvMcBUWDWVQhVIzGNvAnYhbUbkKq1qwKedUFHb9XaWxprjWUMsGXFp d8it/Gm1As9tz5JQg6i/Dlty5TZKwJNwTHyX/AspHP1QzomlfncRto+LAGSMozMu 8LEGWHohlMTbEmsi1hqXqRK4MANPCGt6Hq5233wahxVqaUT7GT1SkWsYFhLstw1V 15z3u9sUX7JaCJUpYrdWVJyQtycYjO0Q8yAtVrFeXKZg/5T37YHhnAnKI738F7f9 a+wu7Vz0ogh8ucbTrXXCkvfqLmC1hHry1Ev3Q/Fqwvd0eCHZH9eCUyN3oVcdEOLY p1OzxJwpSutzAJt3fqGSJST4C9xcY10IS1P+t13PBZqNtD4KDV1FntYPlFgyfNpV QxHhSgVkNsyQUwQrhBa4W2m4mtfq+T5zBWWYTTsRSJvb4UYYoOqumFrHMgLAvf1f XSg93R5RAPq3WvFd22sE =2cWU -----END PGP SIGNATURE-----