From psimerda at redhat.com Tue Jul 29 10:29:11 2014 From: psimerda at redhat.com (Pavel Simerda) Date: Tue, 29 Jul 2014 06:29:11 -0400 (EDT) Subject: [Dnssec-trigger] patch: improve dnssec-trigger-script locking and avoid a dependency In-Reply-To: <1917761486.8719151.1406629592662.JavaMail.zimbra@redhat.com> Message-ID: <201453767.8719336.1406629751412.JavaMail.zimbra@redhat.com> Hi, the python lockfile module doesn't handle stale locks properly. It turned out that using fcntl.flock handles that and doesn't need any additional dependencies. Patch included. Tested with Python 3.x and 2.x. Pavel -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-avoid-stale-locks-by-using-fcntl.patch Type: text/x-patch Size: 1919 bytes Desc: not available URL: From psimerda at redhat.com Thu Jul 31 10:20:00 2014 From: psimerda at redhat.com (Pavel Simerda) Date: Thu, 31 Jul 2014 06:20:00 -0400 (EDT) Subject: [Dnssec-trigger] dnssec-trigger & autotools In-Reply-To: <878579675.9377168.1406801898121.JavaMail.zimbra@redhat.com> Message-ID: <2032937356.9377748.1406802000973.JavaMail.zimbra@redhat.com> Hi, could we modify the dnssec-trigger source tree so that it also uses automake. I think it would be easier to maintain and it would also help to separate a shared library that would be usable without the daemon if necessary. Pavel From wouter at nlnetlabs.nl Thu Jul 31 10:36:28 2014 From: wouter at nlnetlabs.nl (W.C.A. Wijngaards) Date: Thu, 31 Jul 2014 12:36:28 +0200 Subject: [Dnssec-trigger] dnssec-trigger & autotools In-Reply-To: <2032937356.9377748.1406802000973.JavaMail.zimbra@redhat.com> References: <2032937356.9377748.1406802000973.JavaMail.zimbra@redhat.com> Message-ID: <53DA1C2C.8000506@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Pavel, On 07/31/2014 12:20 PM, Pavel Simerda wrote: > Hi, > > could we modify the dnssec-trigger source tree so that it also > uses automake. I think it would be easier to maintain and it would > also help to separate a shared library that would be usable without > the daemon if necessary. You can do that; but it has to work and that is hard. I think it is likely very difficult, because of the ifdefs in the Makefile that we need for OSX and Windows targets and all the variability. Also automake has weird version dependencies. Best regards, Wouter -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT2hwnAAoJEJ9vHC1+BF+NyQYP/AghMwcDwCem7GvLCqzmJNyw N4cEuRM9ly9vhS86KdlFPy6z/9+0x7Gag5C9LbbgAPvB/FjF6JaYeI3MDj0V8gg6 bL+n1YPbdkybRf6kq/n+sJDvGQfMYb1EEw7RTU9JqYkqj6gKv9filkQqM+7QakNz 8NNlcegiB61jrS4CwRLeBnvAdgdtJz08diqh1uJeZtN2LXTY1sSTOeYXtn8OPmGb X1VSfdC6lOxbxumazirRER4or0VmCuVTw1CQyJZ6Tvd041tKgOaSOL97yTdvFiRi ipBzNNcrpD43EZnWW4K7+IOGNyfFC/aqq5h/anUtvNXppJFv11Fy7KzIIfIKPNuN 8l6xjCRq/2CafFt6dYqnWGJag2/Ysx5YQSV5Y2pwttON4lmebVK6X1KATXyxceKC TtQB/5rfz0pUcHYL35EPKFnRybBIxUpkpsESqZW5rDZPcGiSVpyPkkgg79YU4TiU GKR4U6XyI0xFolVkTPe49yUQGfA1PEAk5CwmQxYOARqzMOtdTVh/y4mvCyJACNqi a8AVUIbCI+R2rMlTdDO7YSPnCrtN9mRjNfZHnkHTDX7kw+yW1+Nc0N7QOFpElQzJ IelpbOvkcTCJ/Dzd1xvkvgDpxQZUsRC0NPZ+ZFl66RohVEr7qW2EclfSBBv0L6IP rdSZak3hOfUT+A6auE0q =EB+/ -----END PGP SIGNATURE----- From wouter at nlnetlabs.nl Thu Jul 31 13:14:08 2014 From: wouter at nlnetlabs.nl (W.C.A. Wijngaards) Date: Thu, 31 Jul 2014 15:14:08 +0200 Subject: [Dnssec-trigger] patch: improve dnssec-trigger-script locking and avoid a dependency In-Reply-To: <201453767.8719336.1406629751412.JavaMail.zimbra@redhat.com> References: <201453767.8719336.1406629751412.JavaMail.zimbra@redhat.com> Message-ID: <53DA4120.1010802@nlnetlabs.nl> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Pavel. On 07/29/2014 12:29 PM, Pavel Simerda wrote: > Hi, > > the python lockfile module doesn't handle stale locks properly. It > turned out that using fcntl.flock handles that and doesn't need any > additional dependencies. > > Patch included. Tested with Python 3.x and 2.x. Thanks, committed. Best regards, Wouter -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT2kEgAAoJEJ9vHC1+BF+NBFwP/R5MMyXMuNzjTGdUO1qIEP8O 3WSoXiDrEFVweKoUm/MLNmU+ylJEWF+9GeAlDmQphHVmuJxSzNZgMI2utO7QBdsJ 08cQF2L+C0yh1BhZWKbWmZUem/WkA1Pc/kYKxYyrUIHaEKiixWK4VJBtzOJqg+G6 qC32wDkQ7jmO1t0KeETl6dDEplqfc8duyM8wfGOcdj6mKEhLWmhyd/NhIiJODfTP m/2eTypkyepspmcasx8g0mOicr8pFZq1qOJfiI+98SQe5HEWmUiSj6FRkO85GsD5 6om8xdfPRlg7cbW0CwFNDMTxLUUVZ6F8ESVforsKn6IINtx+mY9XvB4dhDT1MljE bqj7opzjBFqd1dCNcumZ41hlzy/Itz8d3c6HqbkfszQciksGJaXkSQWA5e7dcdF+ O/OVgRrnDIMI2aa8MdBR3q6sWewvF/dXnTnMsnX33t9eb1GCohc8/FlEJCLFEoQL tjF57kTidl8T0jufSR9FHkJuEE3P82YKIlF9LGX3skWlt8c+eotVRTMhDPVOuEUv QmhRysODD45f7w6lbSRGr3elx0H39pSLvtVDCL7CFU7UV96YZPE1ATVQejj07rto LHPikW1DVOb4uS8j+oKlRGz540pyqQ1sj9uai3UZ/1m+xmae7+1vDUCjEWlrEh4i sqk7CUNZXku39ltVPM/7 =wQ+3 -----END PGP SIGNATURE-----