[Dnssec-trigger] 0.11 uses wrong nmcli parameters on NM > 0.9.[34]

[W.C.A. Wijngaards]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Paul,

On 06/29/2012 07:12 PM, Paul Wouters wrote:
> 
> It seems the nmcl syntax has changed.
> 
> For Fedora 16 and 17, I needed:
> 
> ips="`$nmcli -f IP4,IP6 dev list | fgrep 'DNS' | awk '{print
> $2;}'`"
> 
> instead of:
> 
> ips="`$nmcli -f IP4-DNS,IP6-DNS dev list | awk '{print $2;}'`"
> 
> It seems this change was made in NetworkManager 0.9.3 or 0.9.4. 
> (0.9.3 never shipped in Fedora)
> 
> I've fired of builds with this change for F16 anf F17, but perhaps
> dnssec-trigger should check using nmcli -v ?
> 
> something like:

Committed this to the svn (but moved to comment to the other part of
the if-else, if the IP-DNS syntax that is the old one?) :-)

Thanks for the patch!

Best regards,
   Wouter

> 
> $nmcli -f IP4-DNS dev list > /dev/null 2>/dev/null RETVAL=$? if [
> $RETVAL = 0 ] ; then ips="`$nmcli -f IP4-DNS,IP6-DNS dev list | awk
> '{print $2;}'`" else # NM < 0.9.4 ips="`$nmcli -f IP4,IP6 dev list
> | fgrep 'DNS' | awk '{print $2;}'`" fi
> 
> Paul
> 
> 
> _______________________________________________ dnssec-trigger
> mailing list dnssec-trigger at NLnetLabs.nl 
> http://open.nlnetlabs.nl/mailman/listinfo/dnssec-trigger

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJP8VtQAAoJEJ9vHC1+BF+NfdkP/jeCXqfA/FTTlby+KQXg0m2B
gmCm3hZ9Jnhs7f6J0gqFMWmLp04oo2FWEE65FHbO9OJAJq25q8yOTcYIZTkTAgay
nl4PZ6++YJ8yWcVkIWsxEM2at9dNvolm2ZuSZiEhw674aafAj6c9axKiMJlml7Hs
ElZK7nMvR8/OCc+DlTTBALmNdsC8krnthyfsfYuQiRudqa66e956RkLVw6n7936a
k30stUh/dwnugsbTawlw6pvLGyXxHme8+8xXEpY3J/o89prdJb6HvwBDz9cbBUuE
Fsu27Dkh0++5uZhG5D/wjKoEnloPuT6np36Q1dl0DBQn0jPbVUiLk14vVlYGqoM8
fespIwC6tiifDIt4+ii14BqOzxH35hvGKth9mkultJ9rHjsUnwmWE7Hp7wj7cMza
scfMuWIJnhvPLogNhaGz8I0aXVlZ+EbwhvSM0Vw3lJTpMwqPFFHG5/F42AGOs84A
VSPcPsU0CKVTM4d2N3shkPjFOvKFgzcand3mdOBtT8s/l/lscIHsQfv61bIAJJOT
OC27IKZemxGnIveefTGD4vkORR4eQoAWhObs87BYEDd8cLpd91ah+BxWYAN5TXp/
qZberKtMHA/a+ZnOtDM33HhuwVTjANHHZzFTnm6RrekxAM4SyN8bL2NVLS4umdPP
otXcwdlMew5/6A1EV8f0
=X6DN
-----END PGP SIGNATURE-----